Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mirage Implementation #7969

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Jul 15, 2024

Replace ember-cli-mirage with ember-mirage. This new, much more embroider compatible, addon is the way forward for mirage support.

Last commit is the annoying one as it changes all the import paths.

[EDIT: ST 2024/07/16] for reference: https://github.com/bgantzler/ember-mirage/blob/main/docs/migration.md

@jrjohnson jrjohnson marked this pull request as ready for review July 16, 2024 01:02
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Replace ember-cli-mirage with ember-mirage. This new, much more embroider compatible, addon is the way forward for mirage support.
This isn't needed anymore as ember-mirage doesn't run in development by
default.
With ember-mirage we lose a lot of the automagic configuration and detection of our factories and models as well as auto calling the `mirage/config` to setup the server. Instead we can just export all this information in common and import it explicitly into our config in each app.
We now provide the mirage server creation explicitly in our tests so we
need to call it from a different place.
I'm not sure why I grabbed the ember data import, but I think relying on
the standard is better for us.
This import requires us to be using ember-cli-mirage and we aren't
anymore. Plus we were barely using it here and can just as easily check
these values ourselves.
@jrjohnson jrjohnson enabled auto-merge July 16, 2024 16:30
@jrjohnson jrjohnson merged commit 1bf1564 into ilios:master Jul 16, 2024
36 checks passed
@jrjohnson jrjohnson deleted the migrate-ember-mirage branch July 16, 2024 17:39
@jrjohnson jrjohnson mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants